#[pg_guard] cleanup #526
Merged
#[pg_guard] cleanup #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new function to pgx-pg-sys, `create::submodules::postgres_function_guard()` and teach the `#[pg_guard]` macro to use that function instead of duplicating all the sigsetjmp code for every function.
…writer` from build.rs. Also eliminate a bit of cloning from build.rs as well. This drastically improves pgx-pg-sys build times. On my machine, a clean build of the crate goes from ~36s to ~18s. And subsequent rebuilds (where build.rs doesn't run) goes from ~8s to ~2.4s
…tions, which decreases subsequent pgx-pg-sys rebuilds (where build.rs needs to run) by ~50%.
Hoverbear
reviewed
Apr 4, 2022
Hoverbear
reviewed
Apr 4, 2022
Hoverbear
approved these changes
Apr 4, 2022
eeeebbbbrrrr
commented
Apr 4, 2022
Yes, on my machine a rebuild of It's quite significant. |
|
Way to go! I'm happy to see this merge, you seem to have a couple pending todos according to comments though! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centralizes all the code
#[pg_guard]otherwise generates into a common function, which takes a closure that is a wrapper around the desired internal Postgres function call.