Filter all
to both config && Cargo .tomls
#1487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our support for a given Postgres version, for an extension crate, is informed by two things:
pg_config
s, defaulting to"${PGRX_HOME}/config.toml"
"pg{major}"
feature.Interpret
cargo-pgrx {start,stop,test} all
to act only on versions for which both of these are present. We will simply filter silently without note because there are some nuances for when we should (not) emit errors that I am not entirely settled on how to decide, but ultimately this allows e.g. an extension like PL/Rust that never supported the same version minimum as pgrx to still usecargo pgrx test all
, and causes less confusing errors whenconfig.toml
includes out-of-date versions unless those are also in Cargo.toml.Note this doesn't prevent us from emitting errors: instead the error moves to when building the pgrx library. Currently it is first caught by cargo when the extension's Cargo.toml doesn't include the features to for the request from cargo-pgrx, but this is a hidden behavior of cargo-pgrx. The failed build of the library is easier to diagnose.
Closes #1421