Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsupported pg version in ~/.pgrx/config.toml isn't handled #1421

Closed
workingjubilee opened this issue Dec 1, 2023 · 1 comment · Fixed by #1487
Closed

unsupported pg version in ~/.pgrx/config.toml isn't handled #1421

workingjubilee opened this issue Dec 1, 2023 · 1 comment · Fixed by #1487
Labels
blocks-0.12.0 bug Something isn't working cargo-pgrx

Comments

@workingjubilee
Copy link
Member

workingjubilee commented Dec 1, 2023

We never actually remove an old version like pg11 from the config.toml, and it's not clear we should. We can tell the user they need to intervene, but we probably should correctly identify when they must. Currently PG_VERSION=all cargo pgrx test doesn't work for my local installation.

Sample busted toml:

[configs]
pg16 = "/home/jubilee/.pgrx/16.0/pgrx-install/bin/pg_config"
pg13 = "/home/jubilee/.pgrx/13.12/pgrx-install/bin/pg_config"
pg12 = "/home/jubilee/.pgrx/12.16/pgrx-install/bin/pg_config"
pg11 = "/home/jubilee/.pgrx/11.21/pgrx-install/bin/pg_config"
pg14 = "/home/jubilee/.pgrx/14.9/pgrx-install/bin/pg_config"
pg15 = "/home/jubilee/.pgrx/15.4/pgrx-install/bin/pg_config"
@workingjubilee
Copy link
Member Author

this really ought to be taken care of before our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocks-0.12.0 bug Something isn't working cargo-pgrx
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant