Include varlena functions #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's already a pgrx::varlena module but this header brings utility fonctions to manipulate GUC variables and identifiers.
To clarify, most of that cannot actually be defined via bindgen, because bindgen does not "do" function macros. @daamien Please find and include the additional headers for varlenas like varatt.h, and explicitly include them even if they are transitively included already. |
|
Note that varatt.h is a recent split-off header so this will actually differ from version to version. |
|
I don't see any macros in the varlena header file... Am I missing something ? I can add |
|
Apologies, the comment about macros was only related in my own head, I think.
Sure. |
|
Thank you! |
workingjubilee
pushed a commit
that referenced
this pull request
Jan 24, 2024
There's already a pgrx::varlena module but utils/varlena.h adds functions to manipulate GUC variables and identifiers. Includes utils/sortsupport.h as a transitive inclusion, along with varatt.h which is already transitively included.
Merged
workingjubilee
added a commit
that referenced
this pull request
Jan 25, 2024
The pgrx 0.11.3 release addresses a few UB risks in pgrx, updates its dependencies on many points, and includes many additional headers. It should also now be easier to use cargo-pgrx on more-complicated network configurations. ## New Bindings! New bindings added thanks to - @burmecia in #1432 - @daamien in - #1431 - #1485 - @rebasedming in #1486 - @usamoi in #1436 - @workingjubilee in #1453 ## "...wait, that's UB?" Two UB fixes! - Thanks to @Lokathor in #1443 - Thanks to @usamoi in #1466 ## Ergonomics - A better `ereport!` macro in #1472 ## Less transport-level security problems in cargo-pgrx - We no longer secretly require rustls! Thanks to @jirutka in #1448 - We now use native certs if possible, even with rustls, since #1449 Together these should mean it's possible to actually use cargo-pgrx on whatever your network configuration is, but you might have to use `cargo install --no-default-features --features native-tls` to install with native-tls (which, on Linux, means OpenSSL). By default, you will use rustls. ## Many dependency updates These address some largely-hypothetical security risks, but one is particularly important: the bindgen update means we now should be compatible with some aarch64 builds that might have failed. - #1492 - #1493 - #1494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's already a pgrx::varlena module but this header brings utility fonctions to manipulate GUC variables and identifiers.