Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No xact callback for spi mutability #1104

Merged
merged 1 commit into from
Apr 19, 2023

Commits on Apr 18, 2023

  1. pgx probably shouldn't use register_xact_callback to help track a…

    … transaction's mutability. This can cause problems if for some reason the pgx extension is unloaded from a running postgres backend as Postgres will still have a pointer to the transaction hook function that has now been unloaded.
    
    Instead, we can easily use the current `TransactionId` to determine if the transaction has been mutated yet, which still allows us (more correctly, even), to ensure Spi sets the `read_only` flag appropriately when executing a statement.
    
    This also gets rid of the need for a pgx-specific static.
    eeeebbbbrrrr committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    2f4f3b2 View commit details
    Browse the repository at this point in the history