No xact callback for spi mutability #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeeebbbbrrrr
force-pushed
the
no-xact-callback-for-spi-mutability
branch
from
f37c138
to
7098dd4
Compare
… transaction's mutability. This can cause problems if for some reason the pgx extension is unloaded from a running postgres backend as Postgres will still have a pointer to the transaction hook function that has now been unloaded. Instead, we can easily use the current `TransactionId` to determine if the transaction has been mutated yet, which still allows us (more correctly, even), to ensure Spi sets the `read_only` flag appropriately when executing a statement. This also gets rid of the need for a pgx-specific static.
eeeebbbbrrrr
force-pushed
the
no-xact-callback-for-spi-mutability
branch
from
7098dd4
to
2f4f3b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgx probably shouldn't use
register_xact_callbackto help track a transaction's mutability. This can cause problems if for some reason the pgx extension is unloaded from a running postgres backend as Postgres will still have a pointer to the transaction hook function that has now been unloaded.Instead, we can easily use the current
TransactionIdto determine if the transaction has been mutated yet, which still allows us (more correctly, even), to ensure Spi sets theread_onlyflag appropriately when executing a statement.This also gets rid of the need for a pgx-specific static.