Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated gucs #67

Merged
merged 3 commits into from
Oct 23, 2022
Merged

Remove deprecated gucs #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bf4b9d
Drop deprecated gucs mechanism
mpalmi Oct 14, 2022
9885a69
Update README with removed deprecated GUCs
mpalmi Oct 14, 2022
be273c2
Update version reference in README
mpalmi Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,11 @@ test=> select session_user, current_user, user, current_role;

- The extension is now non-relocatable and all functions are schema-qualified.

### Version 4.0.0-rc1

- Use of GUCs with `whitelist` have been removed from the codebase. Please use
the newer `allowlist` GUCs.

## Licensing

Please see the [LICENSE](./LICENSE) file.
Expand Down
84 changes: 0 additions & 84 deletions deprecated_gucs.h
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions set_user.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
PG_MODULE_MAGIC;

#include "compatibility.h"
#include "deprecated_gucs.h"

#define ALLOWLIST_WILDCARD "*"
#define SUPERUSER_AUDIT_TAG "AUDIT"
Expand Down Expand Up @@ -103,9 +102,6 @@ extern Datum set_user(PG_FUNCTION_ARGS);
void _PG_init(void);
void _PG_fini(void);

DEPRECATED_GUC(nosuperuser_target_whitelist, nosuperuser_target_allowlist, NOSU_TargetWhitelist, NOSU_TargetAllowlist)
DEPRECATED_GUC(superuser_whitelist, superuser_allowlist, SU_Whitelist, SU_Allowlist)

/* used to block set_config() */
static void set_user_object_access(ObjectAccessType access, Oid classId, Oid objectId, int subId, void *arg);
static void set_user_block_set_config(Oid functionId);
Expand Down Expand Up @@ -532,9 +528,6 @@ _PG_init(void)
NULL, &exit_on_error, true, PGC_SIGHUP,
0, NULL, NULL, NULL);

DefineDeprecatedStringVariable(nosuperuser_target_whitelist, nosuperuser_target_allowlist, NOSU_TargetWhitelist, NOSU_TargetAllowlist);
DefineDeprecatedStringVariable(superuser_whitelist, superuser_allowlist, SU_Whitelist, SU_Allowlist);

/* Install hook */
prev_hook = ProcessUtility_hook;
ProcessUtility_hook = PU_hook;
Expand Down