Squid - dashboard widget bootstrap facelift + fixes #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
doktornotor
commented
Jan 27, 2017
•
doktornotor
commented
- replace inline base64 images with bootstrap icons
- tidy up tables and remove old styling
- fix squiclamav version detection and use pkg_exec() to get packages' versions in general
- fix version and HTML on squid_clwarn.php page
added 2 commits
January 27, 2017 22:41
- replace inline base64 images with bootstrap icons - tidy up tables and remove old styling - fix squiclamav version detection and use pkg_exec() to get packages' versions in general
rbgarga
requested changes
Jan 30, 2017
| @@ -19,7 +19,9 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| $VERSION = '6.10'; | |||
| require_once("pkg-utils.inc"); | |||
| pkg_exec("query '%v' squidclamav", $version, $err); | |||
There was a problem hiding this comment.
It's missing to check pkg_exec return code to make sure it succeeded
There was a problem hiding this comment.
Well it is working perfectly fine here? confused The version is in $version
There was a problem hiding this comment.
pkg_exec returns 0 for success and != 0 when it fails. It would be good to check if return is 0 before assume $version really contains a valid value
rbgarga
approved these changes
Jan 30, 2017
|
@rbgarga - No idea what scripts are you guys using for the cherrypick stuff, but they are broken. Completely screwed people's access to WebGUI. https://forum.pfsense.org/index.php?topic=124814.msg689342#msg689342 Can we get rid of this licensing schizo, perhaps? |
|
@doktornotor fixed. Thanks! |
netgate-git-updates
pushed a commit
that referenced
this pull request
Jan 17, 2023
ChangeLog: [decof/du/tru64] Remove support because the os is no longer updated for more than 10 years [openstep/nextstep] Remove support because the os is no longer updated for more than 20 years Add experimental build system based on Autotools (#270) Fixed LTsock testing on darwin (#272) Remove NEW and OLD folders (#6) Fix FreeBSD testcases (#271) Rewrite documentation and publish at https://lsof.readthedocs.io/
netgate-git-updates
pushed a commit
that referenced
this pull request
Jun 24, 2023
ChangeLog: https://www.nlnetlabs.nl/news/2023/Jun/07/nsd-4.7.0-released/ 4.7.0 ================ FEATURES: - Merge #263: Add bash autocompletion script for nsd-control. - Fix #267: Allow unencrypted local operation of nsd-control. - Merge #269 from Fale: Add systemd service unit. - Fix #271: DNSTAP over TCP, with dnstap-ip: "127.0.0.1@3333". - dnstap over TLS, default enabled. Configured with the options dnstap-tls, dnstap-tls-server-name, dnstap-tls-cert-bundle, dnstap-tls-client-key-file and dnstap-tls-client-cert-file. BUG FIXES: - Fix #239: -Wincompatible-pointer-types warning in remote.c. - Fix configure for -Wstrict-prototypes. - Fix #262: Zone(s) not synchronizing properly via TLS. - Fix for #262: More error logging for SSL read failures for zone transfers. - Merge #265: Fix C99 compatibility issue. - Fix #266: Fix build with --without-ssl. - Fix for #267: neater variable definitions. - Fix #270: reserved identifier violation. - Fix to clean more memory on exit of dnstap collector. - Fix dnstap to not check socket path when using IP address. - Fix to compile without ssl with dnstap-tls code. - Dnstap tls code fixes. - Fix include brackets for ssl.h include statements, instead of quotes. - Fix static analyzer warning about nsd_event_method initialization. - Fix #273: Large TXT record breaks AXFR. - Fix ixfr create from adding too many record types. - Fix cirrus script for submit to coverity scan to libtoolize the configure script components config.guess and config.sub. - Fix readme status badge links. - make depend. - Fix for build to run flex and bison before compiling code that needs the headers. - Fix to remove unused whitespace from acx_nlnetlabs.m4 and config.h. - For #279: Note that autoreconf -fi creates the configure script and also the needed auxiliary files, for autoconf 2.69 and 2.71. - Fix unused variable warning in unit test, from clang compile. - Fix #240: Prefix messages originating from verifier. - Fix #275: Drop unnecessary root server checks. PR: 272096 Reported by: [email protected] (maintainer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.