Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status / Monitoring - Graph Refresh Enhancement #240

Conversation

NOYB
Copy link
Contributor

@NOYB NOYB commented Dec 22, 2016

Immediately apply refresh interval setting change.
Option for settings changes to dynamically refresh graphs.

Immediately apply refresh interval setting change.
Option for settings changes to dynamically refresh graphs.
@jdillard
Copy link
Contributor

I don't think this is worth the complexity that it adds when having to support it during potential future changes. It also doesn't account for the case of the user wanting to refresh on settings change and also wants to refresh on an interval.

@jdillard jdillard closed this Dec 28, 2016
@NOYB
Copy link
Contributor Author

NOYB commented Jan 4, 2017

Simply refactors the existing little "scheduling" in-line code blurb into a function so it can be called by a handler.
The only additional code is the handler and it is not hardly complex. Supporting it during potential future changes is a nit, as potential future changes should be including this capability anyway. In which case it would not be additional complexity.

As for not accounting for the case of user wanting to refresh on settings change while an interval is selected. The existing code doesn't account for refresh on settings change at all. For any of the settings. So not being part of the timed refresh interval settings really is moot. Even so a simple expression in the if statement can easily provide that.

Not only that but the user can't even make a refresh interval change at all without saving a view and reloading the entire page. Overly cumbersome just to turn on/off or even just change the refresh interval of a graph being viewed.

This provides 2 quite valuable features with nearly no new code and very infinitesimal complexity.

  1. Ability to enable/disable/change refresh interval dynamically in real-time (on the fly). Without having to save the graph as a view and reload the entire page.
  2. Ability to dynamically change graph settings in real-time (on the fly). Without having to reload the page.

These features are quite useful. Especially dynamic graph update on settings change. Convenient for looking though graphs with different time periods, resolutions, graph types, etc. Others would probably find them useful too if available to them.

netgate-git-updates pushed a commit that referenced this pull request Jun 24, 2022
Required for gitlab-ce 15.1.
Changelog:
https://github.com/pganalyze/pg_query/blob/main/CHANGELOG.md

2.1.3 2022-01-28

    Track tables in EXCEPT and INTERSECT queries (#239)
    Get filter_columns working with UNION/EXCEPT/INTERSECT (#240)
    Update google-protobuf to address CVE scanner complaints
        Note that none of the CVEs apply to pg_query, but this avoids unnecessary errors when the google-protobuf dependency is pulled in
netgate-git-updates pushed a commit that referenced this pull request Sep 26, 2022
Back port a patch from the dmidecode upsteam that resolves a crash when
reading the Attribute #240 on some HP hardware.

See
https://git.savannah.nongnu.org/cgit/dmidecode.git/commit/?id=c3357b532941a8df387618e692e522cc7a43b3e8

Approved by:	portmgr blanket
Sponsored by:	Klara Inc.
netgate-git-updates pushed a commit that referenced this pull request Sep 26, 2022
ChangeLog:

               [FreeBSD] configure: suggest variable to set if FreeBSD
sys not
               found
               submitted by @emaste

		Updated 00FAQ with lookup to open files via mountpoint
		Provided by Jacob Chapman in #240

                [FreeBSD] modernize API usage and remove legacy FreeBSD
releases
                Contributor DamjanJovanovic (#184) Ed Maste (#250, #251,
                Warner Losh (#253)
netgate-git-updates pushed a commit that referenced this pull request Jun 24, 2023
ChangeLog: https://www.nlnetlabs.nl/news/2023/Jun/07/nsd-4.7.0-released/

4.7.0
================
FEATURES:
- Merge #263: Add bash autocompletion script for nsd-control.
- Fix #267: Allow unencrypted local operation of nsd-control.
- Merge #269 from Fale: Add systemd service unit.
- Fix #271: DNSTAP over TCP, with dnstap-ip: "127.0.0.1@3333".
- dnstap over TLS, default enabled. Configured with the
  options dnstap-tls, dnstap-tls-server-name, dnstap-tls-cert-bundle,
  dnstap-tls-client-key-file and dnstap-tls-client-cert-file.

BUG FIXES:
- Fix #239: -Wincompatible-pointer-types warning in remote.c.
- Fix configure for -Wstrict-prototypes.
- Fix #262: Zone(s) not synchronizing properly via TLS.
- Fix for #262: More error logging for SSL read failures for zone
  transfers.
- Merge #265: Fix C99 compatibility issue.
- Fix #266: Fix build with --without-ssl.
- Fix for #267: neater variable definitions.
- Fix #270: reserved identifier violation.
- Fix to clean more memory on exit of dnstap collector.
- Fix dnstap to not check socket path when using IP address.
- Fix to compile without ssl with dnstap-tls code.
- Dnstap tls code fixes.
- Fix include brackets for ssl.h include statements, instead of quotes.
- Fix static analyzer warning about nsd_event_method initialization.
- Fix #273: Large TXT record breaks AXFR.
- Fix ixfr create from adding too many record types.
- Fix cirrus script for submit to coverity scan to libtoolize
  the configure script components config.guess and config.sub.
- Fix readme status badge links.
- make depend.
- Fix for build to run flex and bison before compiling code that needs
  the headers.
- Fix to remove unused whitespace from acx_nlnetlabs.m4 and config.h.
- For #279: Note that autoreconf -fi creates the configure script
  and also the needed auxiliary files, for autoconf 2.69 and 2.71.
- Fix unused variable warning in unit test, from clang compile.
- Fix #240: Prefix messages originating from verifier.
- Fix #275: Drop unnecessary root server checks.

PR:		272096
Reported by:	[email protected] (maintainer)
netgate-git-updates pushed a commit that referenced this pull request Mar 6, 2024
Changes:
- Fix 32-bit compilation
- Add support for BLAKE2s

PR:		277359
Pull Request:	#240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants