Fix locks for git+ssh with credentials. #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously redacted credentials from the Pip download log were embedded in locked artifact URLs rendering the lock unusable. Now credentials are fixed up before the lock file is written. Fixes pex-tool#1918
|
Reviewers - there is definitely thrash going on here with CI, but only CI. The code and tests are good to go; I'm just trying to get cloning of |
benjyw
approved these changes
Sep 30, 2022
|
Alright - I could think of no awesome way to get the git+ssh IT to work on a fork; so I just made the test active on main where an ssh private key secret is available. |
|
Ok - the tests are not being skipped on main and they are going green: https://github.com/pantsbuild/pex/actions/runs/3162686552/jobs/5149591143#step:8:1055 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously redacted credentials from the Pip download log were embedded
in locked artifact URLs rendering the lock unusable. Now credentials are
fixed up before the lock file is written.
Fixes #1918