-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git
username replaced with ****
redaction in lockfile for git+ssh
direct references
#1918
Comments
git
username replaced with ****
redaction in lockfile for private git repo direct referencesgit
username replaced with ****
redaction in lockfile for git+ssh
direct references
Relevant bit where pip redacts this: https://github.com/pypa/pip/blob/main/src/pip/_internal/utils/misc.py#L456 |
I filed pantsbuild/pants#15410 a while ago, but this is the same issue for me. It's blocking me cloning a repo in my CI but oddly works locally fine.
|
Previously redacted credentials from the Pip download log were embedded in locked artifact URLs rendering the lock unusable. Now credentials are fixed up before the lock file is written. Fixes pex-tool#1918
Previously redacted credentials from the Pip download log were embedded in locked artifact URLs rendering the lock unusable. Now credentials are fixed up before the lock file is written. Fixes #1918
Alright @dquig and @engnatha the fix for this is released in Pex 2.1.107 and Pants 2.15.0.dev3 should have that fix with the PR here: pantsbuild/pants#17081 If either of you don't have a workaround (it seems like you do @engnatha) and need the upgrade to Pex 2.1.107 cherry-picked back to Pants 2.14 or 2.13 let me know. |
To reproduce:
The text was updated successfully, but these errors were encountered: