Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pex fails with tensorflow==2.0.0rc0 (probably because of manylinux2010) #763

Closed
zachmoshe opened this issue Aug 28, 2019 · 2 comments · Fixed by #788
Closed

Pex fails with tensorflow==2.0.0rc0 (probably because of manylinux2010) #763

zachmoshe opened this issue Aug 28, 2019 · 2 comments · Fixed by #788
Assignees

Comments

@zachmoshe
Copy link

<<start in a new virtualenv>>
pip install -U pip
# got me pip-19.2.3
pip install pex
# got me pex-1.6.10
pip install tensorflow==2.0.0rc0

pip freeze
# shows:
# absl-py==0.8.0
# astor==0.8.0
# gast==0.2.2
# google-pasta==0.1.7
# grpcio==1.23.0
# h5py==2.9.0
# Keras-Applications==1.0.8
# Keras-Preprocessing==1.1.0
# Markdown==3.1.1
# numpy==1.17.1
# opt-einsum==3.0.1
# pex==1.6.10
# protobuf==3.9.1
# six==1.12.0
# tb-nightly==1.15.0a20190806
# tensorflow==2.0.0rc0
# termcolor==1.1.0
# tf-estimator-nightly==1.14.0.dev2019080601
# Werkzeug==0.15.5
# wrapt==1.11.2

pex -r <(pip freeze) -o tmp.pex
# fails on:
# Could not satisfy all requirements for tensorflow==2.0.0rc0:
#    tensorflow==2.0.0rc0

This only happens when I try tensorflow==2.0.0rc0, for example tensorflow-2.0.0-b1 works fine. It also doesn't happen on macos.
I've noticed that the -b1 version detects the distribution as manylinux1 while rc0 calls it manylinux2010 - could that be the difference?

Any solution or a workaround?

Thanks!

@dcherniv
Copy link

@zachmoshe the only workaround is to repackage tensorflow as manylinux1.

@zachmoshe
Copy link
Author

Thanks @fhoering, #778 helped me! I see it's still open, so I assume you're planning some more long-term support.

For future readers: I installed pex directly from git (got version 1.6.12 rather than 1.6.10 from apt-get), and it solved the problem.

@jsirois jsirois self-assigned this Nov 14, 2019
jsirois added a commit that referenced this issue Nov 14, 2019
This changes Pex to vendor pip and defer all resolution and building to it.

As part of this change some ambiguous and / or broken features were changed and APIs adjusted:
+ The egg distribution format is no longer supported.
+ The deprecated `--interpreter-cache-dir` CLI option was removed.
+ The `--cache-ttl` CLI option and `cache_ttl` resolver API argument were removed.
+ The resolver API replaced `fetchers` with a list of `indexes` and a list of `find_links` repos.
+ The resolver API removed (http) `context` which is now automatically handled.
+ The resolver API removed `precedence` which is now pip default precedence - wheels when available and not ruled out via the `--no-wheel` CLI option or `use_wheel=False` API argument.
+ The `--platform` CLI option and `platform` resolver API argument now must be full platform strings that include platform, implementation, version and abi; e.g.: `--platform=macosx-10.13-x86_64-cp-36-m`.
+ The `--manylinux` CLI option and `use_manylinux` resolver API argument were removed. Instead, to resolve manylinux wheels for a foreign platform, specify the manylinux platform to use with an explicit `--platform` CLI flag or `platform` resolver API argument; e.g.: `--platform=manylinux2010-x86_64-cp-36-m`.

Fixes #781

Additionally:
Fixes #771
Fixes #763
Fixes #761
Fixes #735 
Fixes #694 
Fixes #660
Fixes #658 
Fixes #642
Fixes #641
Fixes #628
Fixes #620
Fixes #614
Fixes #611
Fixes #608
Fixes #439
Fixes #415
Fixes #387
Fixes #315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants