Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pex resolution does not properly constrain sdists. #628

Closed
jsirois opened this issue Nov 28, 2018 · 1 comment · Fixed by #788
Closed

Pex resolution does not properly constrain sdists. #628

jsirois opened this issue Nov 28, 2018 · 1 comment · Fixed by #788
Assignees
@jsirois
Labels
bug resolver

Comments

@jsirois
Copy link
Member

jsirois commented Nov 28, 2018 •
edited
Loading

Right now, we consider all sdists as automatically platform compatible, which is incorrect since an sdist may specify Requires-Python in its PKG-INFO to express the fact the sdist only supports python 3 for example.

Combine this with the fact highest version wins:
https://github.com/pantsbuild/pex/blob/0fd48491df770c7c99bb52a8cb493a636e72a893/pex/sorter.py#L24-L29

And we'll incorrectly pick the latest version of a project when it includes an sdist on pypi even if the wheel(s) beside it are correctly rejected due to py3 being in the wheel name.
@jsirois jsirois mentioned this issue Nov 28, 2018
Merged
@jsirois
Copy link
Member Author

jsirois commented Nov 28, 2018

This looks up to date and the code makes sense: https://pypi.org/project/pkginfo/ - a candidate for vendoring and using to help fix this; although the metadata spec is solid so we could roll our own as well.

@jsirois jsirois self-assigned this Dec 17, 2018
@jsirois jsirois mentioned this issue Jan 7, 2019
Closed
@jsirois jsirois mentioned this issue Jan 23, 2019
Closed
3 tasks
@jsirois jsirois mentioned this issue Feb 6, 2019
Closed
2 tasks
@jsirois jsirois mentioned this issue Mar 10, 2019
Closed
3 tasks
@jsirois jsirois mentioned this issue Mar 26, 2019
Closed
10 tasks
@jsirois jsirois mentioned this issue Nov 14, 2019
Merged
jsirois added a commit that referenced this issue Nov 14, 2019
@jsirois
Use pip for resolving and building distributions. (#788)
7509a89 
This changes Pex to vendor pip and defer all resolution and building to it.

As part of this change some ambiguous and / or broken features were changed and APIs adjusted:
+ The egg distribution format is no longer supported.
+ The deprecated `--interpreter-cache-dir` CLI option was removed.
+ The `--cache-ttl` CLI option and `cache_ttl` resolver API argument were removed.
+ The resolver API replaced `fetchers` with a list of `indexes` and a list of `find_links` repos.
+ The resolver API removed (http) `context` which is now automatically handled.
+ The resolver API removed `precedence` which is now pip default precedence - wheels when available and not ruled out via the `--no-wheel` CLI option or `use_wheel=False` API argument.
+ The `--platform` CLI option and `platform` resolver API argument now must be full platform strings that include platform, implementation, version and abi; e.g.: `--platform=macosx-10.13-x86_64-cp-36-m`.
+ The `--manylinux` CLI option and `use_manylinux` resolver API argument were removed. Instead, to resolve manylinux wheels for a foreign platform, specify the manylinux platform to use with an explicit `--platform` CLI flag or `platform` resolver API argument; e.g.: `--platform=manylinux2010-x86_64-cp-36-m`.

Fixes #781

Additionally:
Fixes #771
Fixes #763
Fixes #761
Fixes #735 
Fixes #694 
Fixes #660
Fixes #658 
Fixes #642
Fixes #641
Fixes #628
Fixes #620
Fixes #614
Fixes #611
Fixes #608
Fixes #439
Fixes #415
Fixes #387
Fixes #315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
bug resolver
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pip for resolving and building distributions. jsirois/pex
1 participant
@jsirois