Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some python tools and libraries don't work with symlinked venv site-packages contents. #1542

Closed
jsirois opened this issue Dec 18, 2021 · 0 comments · Fixed by #1543
Closed

Some python tools and libraries don't work with symlinked venv site-packages contents. #1542

jsirois opened this issue Dec 18, 2021 · 0 comments · Fixed by #1543
Assignees
@jsirois
Labels
enhancement feature request

Comments

@jsirois
Copy link
Member

jsirois commented Dec 18, 2021

Notably, pylint, which is used by Pants in a --venv PEX: pylint-dev/pylint#1470

Pex should gain a knob to work around this as needed.
@jsirois jsirois mentioned this issue Dec 18, 2021
Closed
@jsirois jsirois changed the title Some python tools and libraries don's work with symlinked venv site-packages contents. Some python tools and libraries don't work with symlinked venv site-packages contents. Dec 18, 2021
@jsirois jsirois self-assigned this Dec 18, 2021
jsirois added a commit to jsirois/pex that referenced this issue Dec 18, 2021
@jsirois
Add knob for --venv site-packages symlinking.
cf75bdb 
Previously, `--venv` mode PEXes always used symlinks for site-packages
dependencies; now there is a `--venv-site-packages-copies` option to
allow the choice of hard links / copies when symlinks are not understood
by projects installed in site-packages.

Fixes pex-tool#1542
@jsirois jsirois mentioned this issue Dec 18, 2021
Merged
jsirois added a commit that referenced this issue Dec 20, 2021
@jsirois
Add knob for --venv site-packages symlinking. (#1543)
747f090 
Previously, `--venv` mode PEXes always used symlinks for site-packages
dependencies; now there is a `--venv-site-packages-copies` option to
allow the choice of hard links / copies when symlinks are not understood
by projects installed in site-packages.

Fixes #1542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
enhancement feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add knob for --venv site-packages symlinking. jsirois/pex
1 participant
@jsirois