Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Pex to 2.1.58. #13915

Closed
wants to merge 2 commits into from
Closed

Upgrade Pex to 2.1.58. #13915

wants to merge 2 commits into from

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Dec 17, 2021

This brings space and speed improvements for packed venv PEXes as
well as a fix that allows relative paths to ca certs to work (this
is how Pants passes those paths).

Release notes here:

Closes pantsbuild/requirements-perf#2

[ci skip-rust]
[ci skip-build-wheels]

This brings space and speed improvements for packed venv PEXes as
well as a fix that allows relative paths to ca certs to work (this
is how Pants passes those paths).

Release notes here:
+ https://github.com/pantsbuild/pex/releases/tag/v2.1.57
+ https://github.com/pantsbuild/pex/releases/tag/v2.1.58

Closes pantsbuild/requirements-perf#2

[ci skip-rust]
[ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsirois
Copy link
Contributor Author

jsirois commented Dec 18, 2021

Hrm. The pylint IT failure is legit. Appears to have to do with switch to symlinks for --venv mode. Investigating...

@jsirois
Copy link
Contributor Author

jsirois commented Dec 18, 2021

Hrm: pylint-dev/pylint#1470 which grabs pylint-dev/astroid#1253
The latter just landed 2 days ago.

@jsirois
Copy link
Contributor Author

jsirois commented Dec 18, 2021

Yeah - this is a no-go with pylint. I'll have to add something like --venv-symlinks / --no-venv-symlinks to Pex and then use that to work around pylint. I'll close this and proceed with the 2.9.0rc0 release w/o a Pex upgrade.

@jsirois jsirois closed this Dec 18, 2021
@jsirois
Copy link
Contributor Author

jsirois commented Dec 18, 2021

pex-tool/pex#1542

@jsirois jsirois deleted the pex/upgrade branch December 20, 2021 22:13
@jsirois jsirois mentioned this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The maximal subset takes ~4s.
2 participants