Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: profile upsert #652
refactor: profile upsert #652
Changes from all commits
1fbca00
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 33 in server/auth/clients/base.py
server/auth/clients/base.py#L32-L33
Check warning on line 21 in server/auth/clients/local.py
server/auth/clients/local.py#L20-L21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the
ProfilesDAO
instance is properly initialized and that theupsert_user
method handles all necessary exceptions that might occur during the database operation. This is crucial to prevent any runtime errors that could disrupt the user login process.Check warning on line 23 in server/auth/clients/local.py
server/auth/clients/local.py#L23
Check warning on line 25 in server/core/dao/profilesDAO.py
server/core/dao/profilesDAO.py#L25
Check warning on line 32 in server/core/dao/profilesDAO.py
server/core/dao/profilesDAO.py#L31-L32