-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: profile upsert #652
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis pull request refactors the profile upsert functionality by replacing direct database interaction with a DAO (Data Access Object) pattern. The changes involve using the Changes
|
supabase = get_client() | ||
supabase.table("profiles").upsert(data).execute() | ||
profiles_dao = ProfilesDAO() | ||
profiles_dao.upsert_user(data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the ProfilesDAO
instance is properly initialized and that the upsert_user
method handles all necessary exceptions that might occur during the database operation. This is crucial to prevent any runtime errors that could disrupt the user login process.
Codecov ReportAttention: Patch coverage is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
No description provided.