-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: Van der Corput - consider span for resolution check #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! This fixes for the VDC value, but the resolution seems to need to be fixed as well.
Not critical for this PR, but I found a type while reading the header here: Construts --> Constructs
tests/common/test_VanDerCorput.cpp
Outdated
EXPECT_DOUBLE_EQ(2.0 / 8, vdc[3].first); | ||
EXPECT_DOUBLE_EQ(10. / 8, vdc[4].first); | ||
EXPECT_DOUBLE_EQ(6.0 / 8, vdc[5].first); | ||
EXPECT_DOUBLE_EQ(14. / 8, vdc[6].first); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keeping this test? Isn't this still a valid test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured the replaced test would suffice for both. I brought this back and added a separate test for this bugfix.
@jslee02 fixed both the value as well as the resolution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As a note, I still see the type here. Don't need to be fixed by this PR though.
Co-Authored-By: Brian Hou <[email protected]>
Expected behavior for VDC with resolution
0.5
:0, 0.5, 1
.0, 0.5, 1.0, 1.5, 2.0
.Current behavior generates sequence for [0,1] and multiplies with length thus giving
0, 0.5, 1.0
0, 1.0, 2.0
We have been using Van der Corput sequence only for interpolated trajectories with [0, 1] time so it was not an issue.
This PR introduces a test that fails with the current master and proposes a fix.
Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md