Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed getStateSpace return type #536

Merged
merged 4 commits into from
Jul 26, 2019
Merged

fixed getStateSpace return type #536

merged 4 commits into from
Jul 26, 2019

Conversation

vinitha910
Copy link
Contributor

@vinitha910 vinitha910 commented Jul 25, 2019 •
edited by brianhou
Loading

Fix for Issue #535

Fix was tested in libcozmo's StateSpace class.

Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@vinitha910 vinitha910 added the bug label Jul 25, 2019
@vinitha910 vinitha910 requested a review from aditya-vk as a code owner July 25, 2019 20:12
aditya-vk
aditya-vk previously approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@aditya-vk aditya-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@brianhou brianhou added this to the Aikido 0.3.0 milestone Jul 25, 2019
@brianhou
Copy link
Contributor

Thanks for the fix! @aditya-vk can you update the CHANGELOG?

aditya-vk
aditya-vk previously approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@aditya-vk aditya-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jslee02
jslee02 reviewed Jul 25, 2019
View reviewed changes
CHANGELOG.md Outdated
* Distance

* Added methods to rank configurations based on specified metric: [#423](https://github.com/personalrobotics/aikido/pull/423)
* Added weights as optional parameter to rankers: [#484](https://github.com/personalrobotics/aikido/pull/484)
* Updated constness of return type of SE2::getStateSpace(): [#536](https://github.com/personalrobotics/aikido/pull/484)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is incorrect.

@brianhou
Copy link
Contributor

Feel free to merge when Travis is happy!

@brianhou brianhou merged commit a282fb9 into master Jul 26, 2019
@brianhou brianhou deleted the vinitha/bugfix/distanceSE2 branch July 26, 2019 00:43
@brianhou brianhou mentioned this pull request Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jslee02 jslee02 jslee02 left review comments

@brianhou brianhou brianhou approved these changes

@aditya-vk aditya-vk aditya-vk left review comments

@gilwoolee gilwoolee Awaiting requested review from gilwoolee

Assignees

@brianhou brianhou

@aditya-vk aditya-vk

Labels
bug
Projects
None yet
Milestone
Aikido 0.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vinitha910 @brianhou @jslee02 @aditya-vk