-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix const correctness of StateHandle #419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 79.46% 79.49% +0.02%
==========================================
Files 231 231
Lines 5952 5955 +3
==========================================
+ Hits 4730 4734 +4
+ Misses 1222 1221 -1
|
5 tasks
5 tasks
brianhou
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StateHandle
can hold either const State pointer or non-const State pointer, which is determined by template parameter_QualifiedState
._QualifiedState
can beconst [X]State
or[X]State
. However, the current implementation ofStateHandle::getState()
can violates const-correctness for both of const and non-const State.The current
StateHandle
is expended as:which is not const-correct.
This PR fixes
getState()
to be always const-correct for ether case (const/non-const) using SFINAE (std::enable_if
andstd::conditional
) and includes several consequential changes.Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md