Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check OMPL version #15

Merged
merged 1 commit into from
Feb 24, 2016
Merged

Check OMPL version #15

merged 1 commit into from
Feb 24, 2016

Conversation

mkoval
Copy link
Member

@mkoval mkoval commented Feb 22, 2016

As @jslee02 discovered in #12, we apparently require OMPL 1.0.0 or above. I added a version check to our CMakeLists.txt file so this fails gracefully.

add_subdirectory(tests)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this last line keep showing up as changed? It also happened in #14.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. I thought it was a trailing newline, but Github is not showing anything.

@psigen
Copy link
Member

psigen commented Feb 24, 2016

Tested this in 14.04 with:

$ sudo apt-get remove ros-indigo-ompl 
$ sudo apt-get install libompl-dev libompl7
$ catkin build aikido
$ sudo apt-get remove --purge libompl-dev libompl7
$ sudo apt-get install ros-indigo-ompl
$ catkin build aikido

It worked great, but interestingly I think ros-indigo-ompl didn't uninstall cleanly:

[aikido] ==> '/home/parallels/ws/build/aikido/build_env.sh /usr/bin/make cmake_check_build_system' in '/home/parallels/ws/build/aikido'
-- Boost version: 1.54.0
-- Found the following Boost libraries:
--   filesystem
CMake Error at /usr/share/ompl/ompl-config.cmake:87 (file):
  file failed to open for reading (No such file or directory):

    /opt/ros/indigo/include/ompl/config.h
Call Stack (most recent call first):
  CMakeLists.txt:10 (find_package)


CMake Error at CMakeLists.txt:13 (message):
  Aikido requires OMPL 1.0.0 or greater; found .

@mkoval
Copy link
Member Author

mkoval commented Feb 24, 2016

Interesting. I think the ompl-config.cmake file is patched in as part of the bloom-release process. Maybe that's related?

mkoval added a commit that referenced this pull request Feb 24, 2016
@mkoval mkoval merged commit 493f802 into master Feb 24, 2016
@mkoval mkoval deleted the bugfix/ompl_version branch February 24, 2016 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants