Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional body in requests #168

Closed

Conversation

yoh1496
Copy link

@yoh1496 yoh1496 commented Jul 9, 2019

This PR make it possible to send requests with the body parameter to WebDav server.

The prepareRequestOptions function ignores the body parameter in methodOptions.
So, this PR modifies codes to avoid ignoring the parameter and makes options compatible with axios options by renaming body to data.

Please review this.

@perry-mitchell
Copy link
Owner

This might conflict with #165 - which came first. So if that gets merged we might need to revisit this MR.

@perry-mitchell
Copy link
Owner

Webdav might have some serious components rewritten soon, such as the requests library portion or potentially even the whole library. I'll close this as it's not exactly how I'd want to integrate more custom body requests. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants