Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support properties on propfind #165

Conversation

DeepDiver1975
Copy link

This adds new options for the method getDirectoryContents to add PROPFIND properties

@DeepDiver1975
Copy link
Author

looks like axios does not transmit a body for propfind .... still evaluating ...
axios/axios#2270

@perry-mitchell
Copy link
Owner

Hi @DeepDiver1975! Thanks for looking in to this. Might I ask why you'd ever need this? I haven't yet come across a server that'd need data sent on a PROPFIND request, besides the usual headers. If this functionality alters the response body in the wrong way, it'd be quite easy to generate unsupported result structures (as in unsupported by the parsing logic in this client).

@DeepDiver1975
Copy link
Author

Webdav, caldav and carddav have a big number of properties per spec which can be queried for. In addition any property can be set via propset and using propfind these props can also be queried for.

@perry-mitchell
Copy link
Owner

@DeepDiver1975 Makes sense. Could you attempt to add a test for this new functionality, however? I don't feel comfortable adding new functionality which isn't demonstrated or tested, sorry.

We use webdav-server as a dependency which should allow you to write tests against it for most webdav-supported functionality.

@perry-mitchell
Copy link
Owner

@DeepDiver1975 Would you have any time to add the tests soon? I'm preparing a new major version of this library centered around a new requests engine I've written: cowl. There's no restrictions on PROPFIND requests as you mentioned with axios, so I'm not sure what you might recommend in this case.

The new major will be in RC mode for a while in a separate branch - I'll link it here shortly.

@DeepDiver1975
Copy link
Author

@DeepDiver1975 Would you have any time to add the tests soon? I'm preparing a new major version of this library centered around a new requests engine I've written: cowl. There's no restrictions on PROPFIND requests as you mentioned with axios, so I'm not sure what you might recommend in this case.

I did not put any prio to this as long as axios is not capable of submitting PROPFIND.

@DeepDiver1975
Copy link
Author

@perry-mitchell any news on the branch using cowl? I'd like to give that a try ... THX

@perry-mitchell
Copy link
Owner

@DeepDiver1975 Work on cowl stalled a bit, though I do intend on continuing. Issue is that cowl needs streams to be a good fit for this library, and streams don't work with XHRs. So I need to update cowl to use:

  • http/https clients in node
  • fetch in browser
  • fetch in react-native ?

So that'll require a bit more fiddling I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants