Improve UI for info messages #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In addition to reporting errors, it can be useful to use periskop to
report events of interest that are not necessarily errors. Combined
with the sampling capabilities of periskop and the HTTP context, it
can be useful to debug rare events and a better alternative to
grepping through logs.
- This change demonstrates the usage of info messages and improves the
UI to hide missing optional fields like 'class'.
- Changes in client libraries will follow to facilitate creating these
kinds of info messages directly from code.
jcreixell
commented
Jun 29, 2021
| "total_count": 1, | ||
| "severity": "info", | ||
| "created_at": "2019-09-15T11:46:25.333Z", | ||
| "latest_errors": [ |
There was a problem hiding this comment.
for info messages "error" is not the best name (maybe events would be better), but changing it will imply a breaking API change and will need to be considered carefully
rciovati
approved these changes
Jun 29, 2021
jcreixell
added a commit
to periskop-dev/periskop-scala
that referenced
this pull request
Jun 30, 2021
- Periskop's aggregation logic in combination with the ability to
collect HTTP contexts makes it a very powerful tool to expose events
of interest beyond regular exceptions. Examples include
branch-and-compare diffs and inconsistency detection.
- This change introduces ExceptionOccurrence as a type representing
both regular messages and exceptions.
- Periskop has already been updated to handle these cases nicely.
- See periskop-dev/periskop#174
jcreixell
added a commit
to periskop-dev/periskop-scala
that referenced
this pull request
Jun 30, 2021
* Add support to collect messages wihout throwables
- Periskop's aggregation logic in combination with the ability to
collect HTTP contexts makes it a very powerful tool to expose events
of interest beyond regular exceptions. Examples include
branch-and-compare diffs and inconsistency detection.
- This change introduces ExceptionOccurrence as a type representing
both regular messages and exceptions.
- Periskop has already been updated to handle these cases nicely.
- See periskop-dev/periskop#174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
report events of interest that are not necessarily errors. Combined
with the sampling capabilities of periskop and the HTTP context, it
can be useful to debug rare events and a better alternative to
grepping through logs.
UI to hide missing optional fields like 'class'.
kinds of info messages directly from code.