Add support to collect messages without throwables #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Periskop's aggregation logic in combination with the ability to
collect HTTP contexts makes it a very powerful tool to expose events
of interest beyond regular exceptions. Examples include
branch-and-compare diffs and inconsistency detection.
- This change introduces ExceptionOccurrence as a type representing
both regular messages and exceptions.
- Periskop has already been updated to handle these cases nicely.
- See periskop-dev/periskop#174
marctc
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collect HTTP contexts makes it a very powerful tool to expose events
of interest beyond regular exceptions. Examples include
branch-and-compare diffs and inconsistency detection.
both regular messages and exceptions.