Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support special characters #94

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Support special characters #94

merged 1 commit into from
Jan 22, 2018

Conversation

kjetilbk
Copy link
Contributor

@kjetilbk kjetilbk commented Jan 19, 2018

  • Characters like Æ, Ø and Å were interpreted as ? without explicitly passing the content type to the encoder for circe, and adding charset to the json content type.

* Characters like ÆØÅ are no longer interpreted as ?
@codecov
Copy link

codecov bot commented Jan 22, 2018

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   65.11%   65.11%           
=======================================
  Files          22       22           
  Lines         579      579           
  Branches       10       10           
=======================================
  Hits          377      377           
  Misses        202      202
Impacted Files Coverage Δ
...irce/src/main/scala/hammock/circe/CirceCodec.scala 80% <100%> (ø) ⬆️
...re/shared/src/main/scala/hammock/ContentType.scala 85.71% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c7793...348e039. Read the comment docs.

@drskur
Copy link

drskur commented Jan 22, 2018

I use Korean, and I got the same pain.

Copy link
Owner

@pepegar pepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you very much @kjetilbk !

@pepegar pepegar merged commit ef24030 into pepegar:master Jan 22, 2018
@kjetilbk kjetilbk deleted the special-char-support branch January 22, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants