Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special characters are interpreted as ? when using Hammock with Circe #95

Closed
kjetilbk opened this issue Jan 22, 2018 · 3 comments
Closed

Special characters are interpreted as ? when using Hammock with Circe #95

kjetilbk opened this issue Jan 22, 2018 · 3 comments

Comments

@kjetilbk
Copy link
Contributor

Hammock's standard ContentType is text/plain, which Apache's StringEntity and ContentType maps to the encoding ISO-8859-1.

To support UTF-8, this ContentType needs to be application/json.
As Circe is used for encoding and decoding json, I have proposed a solution where HammockEncoderForCirce explicitly passes application/json; charset=utf-8 as the ContentType: #94

Does this look like a viable solution?
@pepegar
Copy link
Owner

pepegar commented Jan 22, 2018

Hello @kjetilbk !

Thanks for catching this and for the pull request. Overall it looks OK, but let me review the PR in depth.

@pepegar pepegar closed this as completed Jan 22, 2018
@pepegar pepegar reopened this Jan 22, 2018
@pepegar
Copy link
Owner

pepegar commented Jan 22, 2018

I didn't intend to close it :)

@kjetilbk
Copy link
Contributor Author

Fix is merged: #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pepegar @kjetilbk