Merge pull request Kuadrant#185 from pehala/fix_labels

Update how labels are handles in OpenshiftObjects
pehala · Mar 23, 2023 · 3377e03 · 3377e03
2 parents bec7095 + e321db9
commit 3377e03
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 20 deletions.
diff --git a/testsuite/openshift/client.py b/testsuite/openshift/client.py
@@ -137,14 +137,10 @@ def create_tls_secret(self, name: str, certificate: Certificate, labels: Optiona
         model: Dict = {
             "kind": "Secret",
             "apiVersion": "v1",
-            "metadata": {
-                "name": name,
-            },
+            "metadata": {"name": name, "labels": labels},
             "stringData": {"tls.crt": certificate.chain, "tls.key": certificate.key},
             "type": "kubernetes.io/tls",
         }
-        if labels is not None:
-            model["metadata"]["labels"] = labels
 
         with self.context:
             return oc.create(model, ["--save-config=true"])

diff --git a/testsuite/openshift/objects/auth_config/__init__.py b/testsuite/openshift/objects/auth_config/__init__.py
@@ -45,13 +45,10 @@ def create_instance(
         model: Dict = {
             "apiVersion": "authorino.kuadrant.io/v1beta1",
             "kind": "AuthConfig",
-            "metadata": {"name": name, "namespace": openshift.project},
+            "metadata": {"name": name, "namespace": openshift.project, "labels": labels},
             "spec": {"hosts": hostnames or route.hostnames},
         }
 
-        if labels is not None:
-            model["metadata"]["labels"] = labels
-
         return cls(model, context=openshift.context)
 
     @modify

diff --git a/testsuite/openshift/objects/auth_config/auth_policy.py b/testsuite/openshift/objects/auth_config/auth_policy.py
@@ -39,18 +39,12 @@ def create_instance(  # type: ignore
         model: Dict = {
             "apiVersion": "kuadrant.io/v1beta1",
             "kind": "AuthPolicy",
-            "metadata": {
-                "name": name,
-                "namespace": openshift.project,
-            },
+            "metadata": {"name": name, "namespace": openshift.project, "labels": labels},
             "spec": {
                 "targetRef": route.reference,
             },
         }
 
-        if labels is not None:
-            model["metadata"]["labels"] = labels
-
         return cls(model, context=openshift.context, route=route)
 
     def add_host(self, hostname):

diff --git a/testsuite/openshift/objects/gateway_api/__init__.py b/testsuite/openshift/objects/gateway_api/__init__.py
@@ -49,17 +49,14 @@ def create_instance(
         model = {
             "apiVersion": "gateway.networking.k8s.io/v1alpha2",
             "kind": "HTTPRoute",
-            "metadata": {"name": name, "namespace": openshift.project},
+            "metadata": {"name": name, "namespace": openshift.project, "labels": labels},
             "spec": {
                 "parentRefs": [parent.reference],
                 "hostnames": [hostname],
                 "rules": [{"backendRefs": [backend.reference]}],
             },
         }
 
-        if labels is not None:
-            model["metadata"]["labels"] = labels  # type: ignore
-
         return cls(model, context=openshift.context)
 
     @property