Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how labels are handles in OpenshiftObjects #185

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Update how labels are handles in OpenshiftObjects #185

merged 1 commit into from
Mar 23, 2023

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Mar 21, 2023

Thanks again @averevki, for suggestion :D

@pehala pehala requested a review from averevki March 21, 2023 10:02
averevki
averevki requested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@averevki averevki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more appearance in the create_tls_secret method.

@pehala
Copy link
Contributor Author

pehala commented Mar 21, 2023

One more appearance in the create_tls_secret method.

fixed

@pehala pehala merged commit 3377e03 into Kuadrant:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averevki averevki averevki approved these changes

@jsmolar jsmolar jsmolar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pehala @jsmolar @averevki