FISH-5802: exclude .gitkeep file from unpacking

[rdebusscher]

Description

The file .gitkeep is not required in the unpacked runtime directory of the Payara Micro instance and its presence prevents using the CDS capabilities fully on JDK17.

Testing

Testing Performed

Testing the creation of the outputlauncher and using it to run an application.

Testing Environment

Zulu 8.52.0.23-CA-macosx (build 1.8.0_282-b08) on Mac 11.8 with Maven 3.8.2

[Pandrex247]

While this works, wouldn't it make more sense simply to not bundle the .gitkeep file in the payara-micro.jar to begin with? It doesn't belong there anyway

[Pandrex247]

Suggested change

	if (fileName != null && !fileName.contains("gitkeep")) {
	if (fileName != null && !fileName.equals(".gitkeep")) {

[rdebusscher]

I tried with excluding the file when payara-micro.jar is assembled, but that breaks the packaging.

 <target name="dumpRuntime">
     <echo message="Dumping Dependencies into the runtime directory" />
    <copy todir="${runtimedir}">
        <fileset dir="${zipdir}">
            <include name="*.jar"/>
            **<exclude name=".gitkeep"/>**
        </fileset>
    </copy>
    <unzip dest="${runtimedir}">
        <fileset dir="${zipdir}">
            <include name="*.zip"/>
            <exclude name="mq**.zip"/>
            **<exclude name=".gitkeep"/>**
        </fileset>
    </unzip>
 </target>

results in

no main manifest attribute, in payara-micro.jar

[rdebusscher]

Closing this as not putting the .gitkeep files in the payara-micro.jar file is a better solution.