Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-5802 Exclude .gitkeep File From Payara Micro #5488

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

Pandrex247
Copy link
Member

@Pandrex247 Pandrex247 commented Nov 5, 2021

Description

Take two of #5456

The file .gitkeep is not required in the unpacked runtime directory of the Payara Micro instance and its presence prevents using the CDS capabilities fully on JDK17.

Important Info

Blockers

None

Testing

New tests

None

Testing Performed

Built and checked manually - no .gitkeep present in any folder within Payara Micro

On JDK 17:

  • java -jar payara-micro.jar --rootdir micro-root --outputlauncher
  • java -XX:ArchiveClassesAtExit=payara.jsa -jar micro-root/launch-micro.jar --warmup --deploymentDir deployment --nocluster
  • java -jar -XX:SharedArchiveFile=payara.jsa micro-root/launch-micro.jar
  • Should start with no errors

Testing Environment

Windows 10, JDK 17.0.1

Documentation

N/A

Notes for Reviewers

I let IntelliJ do a formatting sweep because the indentation of the file made me cringe.
If you want to see the actual functionality change, just look at commit 91f883e

@Pandrex247
Copy link
Member Author

Jenkins test please

Copy link
Contributor

@aubi aubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pandrex247 Pandrex247 merged commit 088291a into payara:master Nov 5, 2021
@Pandrex247 Pandrex247 deleted the FISH-5802 branch November 5, 2021 15:14
JamesHillyard pushed a commit to JamesHillyard/Payara that referenced this pull request Nov 18, 2021
FISH-5802 Exclude .gitkeep File From Payara Micro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants