FISH-1423 disable escaping asadmin

[kalinchan]

Description

Allows the ability to enable/disable escape event

Testing

Testing Performed

Tested by seeing if this the expected outcome is expected, and then setting the env variable AS_ADMIN_DISABLE_EVENT_EXPANSION to false and seeing if it is different

Testing Environment

openjdk version "1.8.0_292"
ubunutu 20.04
maven 3.6.3

Documentation PR

payara/Payara-Community-Documentation#169

Notes for Reviewers

Started by @OndroMih

[kalinchan]

jenkins test please

[Pandrex247]

We probably need a swarm on this to test it on all supported OSs and terminals, across a variety of commands, and comparing against the asadmin recorder - escape characters are finicky.

[lprimak]

simplify system property, fix alignment

[kalinchan]

jenkins test please

[lprimak]

Tabs in the code and 2-space indents still there

[lprimak]

@Pandrex247 Since this PR just passes additional option and has ability to disable it, should this not just be good enough approved for community?
Looks good to me

[lprimak]

jenkins test

[Pandrex247]

@lprimak this is targeted to go into Community and Enterprise at the same time - if anthing other than the default value needs changing we need to keep them in sync so doing the tests here first makes sense to save us having to make a 2nd PR.

Results of testing on Windows (Windows Terminal):

• AS_ADMIN_DISABLE_EVENT_EXPANSION unset (defaults to true)
  • Non-interactive:
    • asadmin create-system-properties 'test_one=colons\:and\=equal\=signs' - works
    • asadmin create-system-properties "test_two=colons\:and\=equal\=signs" - works
    • asadmin create-system-properties test_three=colons\\:and\\=equal\\=signs - doesn't work
      • Needs to be: asadmin create-system-properties test_three=colons\:and\=equal\=signs
  • Interactive:
    • create-system-properties 'test_four=colons\:and\=equal\=signs' - works
    • create-system-properties "test_five=colons\:and\=equal\=signs" - works
    • create-system-properties test_six=colons\\:and\\=equal\\=signs - works
• AS_ADMIN_DISABLE_EVENT_EXPANSION=false
  • Non-interactive:
    • asadmin create-system-properties 'test_seven=colons\:and\=equal\=signs' - works
    • asadmin create-system-properties "test_eight=colons\:and\=equal\=signs" - works
    • asadmin create-system-properties test_nine=colons\\:and\\=equal\\=signs - doesn't work
      • Needs to be: asadmin create-system-properties test_nine=colons\:and\=equal\=signs
  • Interactive:
    • create-system-properties 'test_ten=colons\:and\=equal\=signs' - doesn't work
      • Needs to be: asadmin create-system-properties 'test_seven=colons\\:and\\=equal\\=signs' OR asadmin create-system-properties 'test_seven=colons\\\\:and\\\\=equal\\\\=signs' (both seem to come up with the expected result)
    • create-system-properties "test_eleven=colons\:and\=equal\=signs" - doesn't work
      • Needs to be: asadmin create-system-properties "test_eight=colons\\:and\\=equal\\=signs" OR asadmin create-system-properties "test_eight=colons\\\\:and\\\\=equal\\\\=signs" (both seem to come up with the expected result)
    • create-system-properties test_twelve=colons\\:and\\=equal\\=signs - doesn't work
      • Needs to be: asadmin create-system-properties test_twelve=colons\\\\:and\\\\=equal\\\\=signs

Results of testing on WSL OpenSUSE Leap 15.2 (Windows Terminal):

• AS_ADMIN_DISABLE_EVENT_EXPANSION unset (defaults to true)
  • Non-interactive:
    • asadmin create-system-properties 'test_one=colons\:and\=equal\=signs' - works
    • asadmin create-system-properties "test_two=colons\:and\=equal\=signs" - works
    • asadmin create-system-properties test_three=colons\\:and\\=equal\\=signs - works
  • Interactive:
    • create-system-properties 'test_four=colons\:and\=equal\=signs' - works
    • create-system-properties "test_five=colons\:and\=equal\=signs" - works
    • create-system-properties test_six=colons\\:and\\=equal\\=signs - works
• AS_ADMIN_DISABLE_EVENT_EXPANSION=false
  • Non-interactive:
    • asadmin create-system-properties 'test_seven=colons\:and\=equal\=signs' - works
    • asadmin create-system-properties "test_eight=colons\:and\=equal\=signs" - works
    • asadmin create-system-properties test_nine=colons\\:and\\=equal\\=signs - works
  • Interactive:
    • create-system-properties 'test_ten=colons\:and\=equal\=signs' - doesn't work
      • Needs to be: asadmin create-system-properties 'test_seven=colons\\:and\\=equal\\=signs'
    • create-system-properties "test_eleven=colons\:and\=equal\=signs" - doesn't work
      • Needs to be: asadmin create-system-properties "test_eight=colons\\:and\\=equal\\=signs"
    • create-system-properties test_twelve=colons\\:and\\=equal\\=signs - doesn't work
      • Needs to be: asadmin create-system-properties test_twelve=colons\\\\:and\\\\=equal\\\\=signs

@OndroMih Is this in line with what you expect?

[kalinchan]

@Pandrex247 You are setting the wrong Environment variable, I recently changed it to AS_ADMIN_DISABLE_EVENT_EXPANSION

[Pandrex247]

@kalinchan Not in the code pushed to this branch

[kalinchan]

@Pandrex247 That Environment class you said to use adds that prefix to the String, so it becomes AS_ADMIN_DISABLE_EVENT_EXPANSION

[Pandrex247]

Comment updated with new results.

[OndroMih]

Yes, @Pandrex247, the behavior you observe is expected. This issue is only about fixing multimode, command line execution used to work before as expected. The only case that didn't work for you on Windows is actually also expected - Windows doesn't use \ as escape character and therefore it's not needed to escape it as in Linux shell's. We can't change how Windows escapes characters.

I suggested one small cosmetic change (use the existing Environment instead of creating a new one), otherwise all looks good.

[kalinchan]

jenkins test

[kalinchan]

jenkins test

[Pandrex247]

Jenkins test please