Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-1423 Documentation #169

Merged
merged 6 commits into from
Jun 16, 2021
Merged

FISH-1423 Documentation #169

merged 6 commits into from
Jun 16, 2021

Conversation

kalinchan
Copy link
Member

No description provided.

@kalinchan kalinchan requested review from OndroMih and AlanRoth June 9, 2021 15:26
@kalinchan kalinchan mentioned this pull request Jun 9, 2021
Merged
AlanRoth
AlanRoth suggested changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@AlanRoth AlanRoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add some examples of scenarios where users may wish to enable this feature, under a 'Usage' or 'Examples' heading after the 'Enabling JLine Event Expansion'

.../ROOT/pages/documentation/payara-server/asadmin-commands/enabling-jlink-event-expansion.adoc Outdated Show resolved Hide resolved
.../ROOT/pages/documentation/payara-server/asadmin-commands/enabling-jlink-event-expansion.adoc Outdated Show resolved Hide resolved
@AlanRoth
Copy link
Contributor

AlanRoth commented Jun 9, 2021 •
edited
Loading

Also small pet peeve but I would rename the file to 'Enable JLine Event Expansion' to keep it consistent with other documentation.

@kalinchan
Copy link
Member Author

@AlanRoth @rdebusscher I have made the suggested changes

rdebusscher
rdebusscher suggested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@rdebusscher rdebusscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you briefly describe or link to a description of what JLine Event expansion is/does.

...es/ROOT/pages/documentation/payara-server/asadmin-commands/Enable-JLine-Event-Expansion.adoc Outdated Show resolved Hide resolved
@kalinchan kalinchan requested a review from rdebusscher June 15, 2021 08:48
AlanRoth
AlanRoth approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@AlanRoth AlanRoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalinchan kalinchan merged commit c405804 into payara:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRoth AlanRoth AlanRoth approved these changes

@rdebusscher rdebusscher rdebusscher approved these changes

@OndroMih OndroMih Awaiting requested review from OndroMih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalinchan @AlanRoth @rdebusscher