CUSTCOM-70 Additional Fix to JAXRS Client With Embedded Dependency #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
MattGill98
changed the title
dmatej
suggested changes
Feb 14, 2020
...ent-tracing/src/main/java/fish/payara/requesttracing/jaxrs/client/PayaraTracingServices.java
Outdated
Show resolved
Hide resolved
...ent-tracing/src/main/java/fish/payara/requesttracing/jaxrs/client/PayaraTracingServices.java
Outdated
Show resolved
Hide resolved
...ent-tracing/src/main/java/fish/payara/requesttracing/jaxrs/client/PayaraTracingServices.java
Outdated
Show resolved
Hide resolved
...jersey/src/test/java/fish/payara/samples/classpath/embeddedvsjersey/JerseyClasspathTest.java
Outdated
Show resolved
Hide resolved
dmatej
suggested changes
Feb 14, 2020
...ent-tracing/src/main/java/fish/payara/requesttracing/jaxrs/client/PayaraTracingServices.java
Outdated
Show resolved
Hide resolved
...ent-tracing/src/main/java/fish/payara/requesttracing/jaxrs/client/PayaraTracingServices.java
Outdated
Show resolved
Hide resolved
...ent-tracing/src/main/java/fish/payara/requesttracing/jaxrs/client/PayaraTracingServices.java
Outdated
Show resolved
Hide resolved
.../main/java/fish/payara/microprofile/opentracing/jaxrs/JerseyOpenTracingAutoDiscoverable.java
Outdated
Show resolved
Hide resolved
...main/java/fish/payara/microprofile/opentracing/jaxrs/client/JaxrsClientBuilderDecorator.java
Outdated
Show resolved
Hide resolved
When Payara Embedded is used as a library rather than starting the embedded server, an exception will be thrown when using the JAX-RS client caused by the request tracing service not having initialised. The previous CUSTCOM-70 fix allowed a JAX-RS client request to be built, but executing the request would still throw the same exception. This change allows the request to be executed as well. Additional references to service locators were restricted to the PayaraTracingServices class to coordinate all service discovery in request tracing. This should help prevent future service locator related problems in tracing, or at least make them easier to fix. Signed-off-by: Matt Gill <[email protected]>
The embedded rest client test won't work without a server running. This change creates a simple Grizzly server on a random available port which will be called by the REST client. Signed-off-by: Matt Gill <[email protected]>
dmatej
approved these changes
Feb 17, 2020
|
Jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix.
When Payara Embedded is used as a library rather than starting the embedded server, an exception will be thrown when using the JAX-RS client caused by the request tracing service not having initialised.
The previous CUSTCOM-70 fix allowed a JAX-RS client request to be built, but executing the request would still throw the same exception. This change allows the request to be executed as well.
Important Info
This PR is an extension to #4443, which didn't address the initial problem. The test has been amended to match.
Testing
New tests
Payara Sample test amendment.