Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUSTCOM-70 Fixed jersey-client issues with embedded distros of Payara #4443

Merged
merged 1 commit into from
Jan 22, 2020
Merged

CUSTCOM-70 Fixed jersey-client issues with embedded distros of Payara #4443

merged 1 commit into from
Jan 22, 2020

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Jan 20, 2020

Description

Testing

mvn clean install -TC4 -PQuickBuild,fastest
mvn clean install -PBuildExtras,QuickBuild,fastest -pl :payara-embedded-all
mvn clean install -Ppayara-samples -pl :embedded-vs-jersey

Test suites executed

  • Quicklook Y
  • Payara Samples Y
  • Java EE7 Samples N
  • Java EE8 Samples N
  • Payara Private Tests N
  • Payara Microprofile TCKs Runner N
  • Jakarta TCKs - jaxrs
  • Mojarra N
  • Cargo Tracker N

@dmatej dmatej requested review from pdudits and MattGill98 January 20, 2020 05:39
@dmatej
Copy link
Contributor Author

dmatej commented Jan 20, 2020

Jenkins test please

dmatej
dmatej commented Jan 20, 2020
View reviewed changes
...g/src/main/java/fish/payara/requesttracing/jaxrs/client/JaxrsClientRequestTracingFilter.java

/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part caused problems with embedded.

@dmatej dmatej added the PR: DO NOT MERGE Don't merge PR until further notice label Jan 22, 2020
@dmatej dmatej self-assigned this Jan 22, 2020
CUSTCOM-70 Fixed jersey-client issues with embedded distros of Payara
3536dd9 
- Jersey detected filters and tried them to initialized them even before
  Payara container startup -> RunLevel exception
- Now access to Payara maintained services is postponed to first request
- This access was extracted to own class
- Also removed some unused imports, etc.
@dmatej
Copy link
Contributor Author

dmatej commented Jan 22, 2020

Jenkins test please

@dmatej dmatej removed the PR: DO NOT MERGE Don't merge PR until further notice label Jan 22, 2020
@dmatej dmatej merged commit 13de70a into payara:master Jan 22, 2020
@dmatej dmatej deleted the CUSTCOM-70-embedded branch January 22, 2020 18:51
@MattGill98 MattGill98 mentioned this pull request Feb 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdudits pdudits pdudits left review comments

@MattGill98 MattGill98 MattGill98 approved these changes

Assignees

@dmatej dmatej

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmatej @pdudits @MattGill98