Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUSTCOM-146 Parametrize *Cache maps #4377

Merged
merged 2 commits into from
Jan 8, 2020
Merged

CUSTCOM-146 Parametrize *Cache maps #4377

merged 2 commits into from
Jan 8, 2020

Conversation

pzygielo
Copy link
Contributor

This is refactoring (only private implementation details changed).

Follow-up to @jbee's #4311 (review).

Testing

Testing Performed

Full build (mvn clean install on Travis).

Test suites executed

Only the ones included in step above.

Testing Environment

Ubuntu 16.04.6 LTS
OpenJDK Runtime Environment (build 1.8.0_222-8u222-b10-1ubuntu1~16.04.1-b10)
Maven 3.6.1

@AlanRoth AlanRoth added PR: CLA CLA submitted on PR by the contributor community-contribution labels Dec 13, 2019
@jbee
Copy link
Contributor

jbee commented Dec 13, 2019

jenkins test please

jbee
jbee reviewed Dec 13, 2019
View reviewed changes
Copy link
Contributor

@jbee jbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only copyright end year in header should be updated to 2019.

Saw that in your earlier PR we forgot to check for header.

@pzygielo
Copy link
Contributor Author

copyright end year in header should be updated to 2019.

updated

Saw that in your earlier PR we forgot to check for header.

added headers to UTs in #4381

@pzygielo pzygielo mentioned this pull request Dec 13, 2019
Merged
@Cousjava
Copy link
Contributor

Cousjava commented Jan 8, 2020

Jenkins test please

@Cousjava Cousjava changed the title Parametrize *Cache maps CUSTCOM-146 Parametrize *Cache maps Jan 8, 2020
@Cousjava Cousjava merged commit 670dd11 into payara:master Jan 8, 2020
@pzygielo pzygielo deleted the types branch January 8, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cousjava Cousjava Cousjava approved these changes

@jbee jbee jbee approved these changes

Assignees
No one assigned
Labels
PR: CLA CLA submitted on PR by the contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pzygielo @jbee @Cousjava @AlanRoth