-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTs for HazelcastTimerStore #4311
Conversation
Jenkins test please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pzygielo for having a look and adding some testing. As far as I am aware we do not use plain assert
s so please use JUnit helper methods instead. There is the bigger question if instead of extracting a method to provide full generic type we add the generics to the field instead as it seems to be expected a fix type everywhere anyway. If you feel confident making that change please go ahead and do that.
...s/hazelcast-ejb-timer/src/main/java/fish/payara/ejb/timer/hazelcast/HazelcastTimerStore.java
Show resolved
Hide resolved
...ast-ejb-timer/src/test/java/fish/payara/ejb/timer/hazelcast/HazelcastTimerStoreTestBase.java
Outdated
Show resolved
Hide resolved
...zelcast-ejb-timer/src/test/java/fish/payara/ejb/timer/hazelcast/HazelcastTimerStoreTest.java
Outdated
Show resolved
Hide resolved
...zelcast-ejb-timer/src/test/java/fish/payara/ejb/timer/hazelcast/HazelcastTimerStoreTest.java
Outdated
Show resolved
Hide resolved
@jbee - thanks Jan for checking. I will rebase and update tests.
in separate [at least] commit. |
Jenkins test please |
Description
This isn't a bug fix / feature.
Testing
New tests
Check files changed tab.
Testing Performed
mvn clean install
completed successfullyTest suites executed
All included in
mvn clean install
build.Testing Environment
Ubuntu 16.04.6 LTS
OpenJDK Runtime Environment (build 1.8.0_222-8u222-b10-1ubuntu1~16.04.1-b10)
Maven 3.6.1
Documentation
Notes for Reviewers
Main change in production code: extracted old
listTimers(String[] serverIds)
to new pure function.