PAYARA-3796 Stop checking whether the JNDI name refers to a String ju… #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st use toString instead if the lookup suceeds. Fixes GH payara#3935 Signed-off-by: Steve Millidge <[email protected]>
|
Jenkins test please |
|
Copyright year needs updating |
pdudits
approved these changes
Nov 21, 2019
|
Jenkins test please |
Cousjava
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st use toString instead if the lookup suceeds.
Fixes GH #3935
Signed-off-by: Steve Millidge [email protected]
Description
This is a small enhancement it enables use of other types of custom JNDI resources other than Strings to be injected as ConfigProperties
#3935
The JNDI config source was explicitly testing whether the object looked up via JNDI was assignable to a String. This is unnecessarily restrictive therefore now it just does a toString.
Testing
New tests
Testing Performed
Tested using the GH reproducer.
Test suites executed
Testing Environment
1.8.0_23
Ubuntu Linux version 5.0.0-31-generic (buildd@lgw01-amd64-046) (gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1
18.04.1)) #3318.04.1-Ubuntu SMP Tue Oct 1 10:20:39 UTC 2019Documentation
Notes for Reviewers