Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3822 Ensure AMX Bean is created for metrics after server start #4016

Merged
merged 1 commit into from
Jun 7, 2019
Merged

PAYARA-3822 Ensure AMX Bean is created for metrics after server start #4016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion nucleus/admin/monitor/src/main/java/org/glassfish/admin/monitor/MonitoringBootstrap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
* only if the new code is made subject to such option by the copyright
* holder.
*/
// Portions Copyright [2018] Payara Foundation and/or affiliates
// Portions Copyright [2018-2019] Payara Foundation and/or affiliates

package org.glassfish.admin.monitor;

Expand Down Expand Up @@ -215,6 +215,9 @@ public void event(Event event) {
if (LOGGER.isLoggable(Level.FINE))
LOGGER.log(Level.FINE, "Discovering the XML ProbeProviders from lib/monitor");
discoverXMLProviders();
if (spmd != null) {
spmd.updateAllStatsProviders();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understood the issue is that at restart a problem occurs. If making this null check helps prevent it it must mean that spmd is null which makes me wonder if updateAllStatsProviders needs to be called later or will spmd be initialised at some later stage and this does include the effects of updateAllStatsProviders?

}
}
}

Expand Down