PAYARA-3822 Ensure AMX Bean is created for metrics after server start #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
jGauravGupta
approved these changes
Jun 5, 2019
AlanRoth
approved these changes
Jun 6, 2019
Pandrex247
approved these changes
Jun 6, 2019
jbee
reviewed
Jun 6, 2019
| @@ -215,6 +215,9 @@ public void event(Event event) { | |||
| if (LOGGER.isLoggable(Level.FINE)) | |||
| LOGGER.log(Level.FINE, "Discovering the XML ProbeProviders from lib/monitor"); | |||
| discoverXMLProviders(); | |||
| if (spmd != null) { | |||
| spmd.updateAllStatsProviders(); | |||
There was a problem hiding this comment.
From what I understood the issue is that at restart a problem occurs. If making this null check helps prevent it it must mean that spmd is null which makes me wonder if updateAllStatsProviders needs to be called later or will spmd be initialised at some later stage and this does include the effects of updateAllStatsProviders?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.