Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-2895 Resolve extensive classloading issues #2922

Merged
merged 1 commit into from
Jul 3, 2018
Merged

PAYARA-2895 Resolve extensive classloading issues #2922

merged 1 commit into from
Jul 3, 2018

Conversation

Cousjava
Copy link
Contributor

@Cousjava Cousjava commented Jul 3, 2018

Revert "#2674 fixing several resource handling misses (#2896)"

This reverts commit eaeea99.

@Cousjava Cousjava added this to the Payara 5.183 milestone Jul 3, 2018
@Cousjava Cousjava requested a review from MattGill98 July 3, 2018 10:42
MattGill98
MattGill98 approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@MattGill98 MattGill98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the classloading issues, so LGTM. Worth reopening the original issue, and mentioning the requested changes.

@Cousjava
Copy link
Contributor Author

Cousjava commented Jul 3, 2018

Jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@MattGill98 MattGill98 merged commit 9f80ff4 into payara:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattGill98 MattGill98 MattGill98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Payara 5.183
Development

Successfully merging this pull request may close these issues.
3 participants
@Cousjava @payara-ci @MattGill98