#2674 fixing several resource handling misses #2896
Conversation
|
Jenkins test please |
|
Quick build and test passed! |
| + " table does not exists. Trying to create it."); | ||
| ps = conn.prepareStatement(createTableStatement); | ||
| ps.executeUpdate(); | ||
| try (Statement stmt = conn.createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE, |
There was a problem hiding this comment.
Statement close isn't strictly necessary because when the connection is closed, all of it's statements, and other resources are closed as well.
However, it doesn't hurt and makes for a good coding style as well
|
@lprimak Sorry, I have found some time to do some more fixes. Please review. |
|
too many code changes in formatting, can you handle them so that we can follow up on what's actually changed. |
|
Jenkins test please |
|
Quick build and test failed! |
| */ | ||
| public static PayaraMicroBoot getBootClass() throws InstantiationException, IllegalAccessException, ClassNotFoundException, Exception { |
There was a problem hiding this comment.
Please revert back this declaration and comment as it helps to make it clear what exceptions may be thrown
There was a problem hiding this comment.
Sure. But I'd argue that this Javadoc does not do much to clarify anything.
|
@mulderbaba Do you want me to bring the whitespaces back? |
|
@svendiedrichsen I just want to make sure that I'm not skipping on anything due to heavy load of formatting changes. If you can constrain your changes to the only ones made for resource handling, that'd be great. |
|
GitHub diff screen has a setting "hide whitespace changes" that was very helpful in this case |
|
jenkins test |
|
Quick build and test passed! |
|
@mulderbaba As @lprimak noted you can make Github show the diff without spaces. |
)" This reverts commit eaeea99.
Fixes some of the resource handling issues found by SonarQube in #2674