Add individual padding vars for donut charts #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://patternfly-react-pr-2529.surge.sh |
dlabrecq
force-pushed
the
2528-donut-chart-vars
branch
8 times, most recently
from
ba6c561 to
b0d05d9
Compare
dlabrecq
force-pushed
the
2528-donut-chart-vars
branch
from
b0d05d9 to
6f81b28
Compare
jschuler
requested changes
Jul 17, 2019
packages/patternfly-4/react-charts/src/components/ChartUtils/chart-label.ts
Outdated
Show resolved
Hide resolved
dlabrecq
force-pushed
the
2528-donut-chart-vars
branch
from
6f81b28 to
aefd262
Compare
dlabrecq
force-pushed
the
2528-donut-chart-vars
branch
from
aefd262 to
6174c09
Compare
redallen
approved these changes
Jul 18, 2019
jschuler
approved these changes
Jul 18, 2019
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added individual padding vars in pf-core for each donut chart. (Currently, the donut charts inherit the pie chart's padding property.) That will ensure changes, to the pie chart padding property, do not inadvertently break donut charts.
Also ensured that the donut size is always the minimum of
height/width(default) and thedonutHeight/donutWidthprops. Thus, eliminating the potential to cause layout issues depending on the order in which properties are set.Minor clean up to docs, etc.
Fixes #2528