Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add individual padding vars for donut charts #2528

Closed
dlabrecq opened this issue Jul 16, 2019 · 0 comments · Fixed by #2529
Closed

Add individual padding vars for donut charts #2528

dlabrecq opened this issue Jul 16, 2019 · 0 comments · Fixed by #2529
Assignees
@dlabrecq
Milestone
2019.05

Comments

@dlabrecq
Copy link
Member

dlabrecq commented Jul 16, 2019 •
edited
Loading

Need to add individual padding vars for each donut chart. (Currently, the donut charts inherit the pie chart's padding property.) That will ensure changes, to the pie chart padding property, do not break donut charts.

Also need to ensure that the donut size is always the minimum of height / width (default) and the donutHeight / donutWidth props. This has the potential to cause layout issues depending on the order in which properties are set.

See pf-core vars: patternfly/patternfly#2067
@dlabrecq dlabrecq self-assigned this Jul 16, 2019
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 16, 2019
@dlabrecq
fix(charts): add individual padding vars for donut charts
32e979d 
Fixes patternfly#2528
@dlabrecq dlabrecq mentioned this issue Jul 16, 2019
Merged
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 17, 2019
@dlabrecq
fix(charts): add individual padding vars for donut charts
ece7b85 
Fixes patternfly#2528
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 17, 2019
@dlabrecq
fix(charts): add individual padding vars for donut charts
8ed7872 
Fixes patternfly#2528
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 17, 2019
@dlabrecq
fix(charts): add individual padding vars for donut charts
6a9f666 
Fixes patternfly#2528
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 17, 2019
@dlabrecq
fix(charts): add individual padding vars for donut charts
4a1a2b3 
Fixes patternfly#2528
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 17, 2019
@dlabrecq
fix(charts): add individual padding vars for donut charts
48fdaf0 
Fixes patternfly#2528
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 17, 2019
@dlabrecq
fix(charts): add individual padding vars for donut charts
e5d08d9 
Fixes patternfly#2528
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 17, 2019
@dlabrecq
fix(charts): add individual padding vars for donut charts
ba6c561 
Fixes patternfly#2528
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 17, 2019
@dlabrecq
fix(charts): add individual padding vars for donut charts
b0d05d9 
Fixes patternfly#2528
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 17, 2019
@dlabrecq
fix(charts): add individual padding vars for donut charts
6f81b28 
Fixes patternfly#2528
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 17, 2019
@dlabrecq
fix(charts): add individual padding vars for donut charts
aefd262 
Fixes patternfly#2528
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jul 17, 2019
@dlabrecq
fix(charts): add individual padding vars for donut charts
6174c09 
Fixes patternfly#2528
jschuler pushed a commit that referenced this issue Jul 18, 2019
@dlabrecq @jschuler
fix(charts): add individual padding vars for donut charts (#2529)
771eee8 
Fixes #2528
@rachael-phillips rachael-phillips added this to the Bluebird milestone Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlabrecq dlabrecq

Labels
None yet
Projects
None yet
Milestone
2019.05
Development

Successfully merging a pull request may close this issue.

Add individual padding vars for donut charts dlabrecq/patternfly-react
2 participants
@dlabrecq @rachael-phillips