Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Chart): Fix runtime errors related to theme padding #2430

Merged
merged 1 commit into from
Jul 2, 2019
Merged

fix(Chart): Fix runtime errors related to theme padding #2430

merged 1 commit into from
Jul 2, 2019

Conversation

TheRealJon
Copy link
Contributor

Add more robust logic for setting padding values in Chart component

fix #2429

What:

  • Add new util function for getting padding values from props and falling back to the theme
  • Use new util function in Chart component to get default padding values

@TheRealJon
fix(Chart): Fix runtime errors related to theme padding
c78af03 
Add more robust logic for setting padding values in Chart component

fix #2429
@TheRealJon TheRealJon requested a review from dlabrecq July 2, 2019 17:11
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2430.surge.sh

@TheRealJon TheRealJon requested a review from dgutride July 2, 2019 17:25
tlabaj
tlabaj approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit a4d9f75 into patternfly:master Jul 2, 2019
@TheRealJon TheRealJon deleted the issue-2429 branch July 2, 2019 17:35
@redallen redallen mentioned this pull request Jul 2, 2019
Merged
@redallen
Copy link
Contributor

redallen commented Jul 2, 2019

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgutride dgutride dgutride approved these changes

@tlabaj tlabaj tlabaj approved these changes

@dlabrecq dlabrecq Awaiting requested review from dlabrecq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(Chart component): Malformed padding causes runtime errors
5 participants
@TheRealJon @patternfly-build @redallen @dgutride @tlabaj