Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(Chart component): Malformed padding causes runtime errors #2429

Closed
TheRealJon opened this issue Jul 2, 2019 · 0 comments · Fixed by #2430
Closed

Bug(Chart component): Malformed padding causes runtime errors #2429

TheRealJon opened this issue Jul 2, 2019 · 0 comments · Fixed by #2430
Milestone

Comments

@TheRealJon
Copy link
Contributor

Consumer passes padding values via the theme prop in the Victory BlockProps form:

{
  bottom?: number;
  left?: number;
  right?: number;
  top?: number;
}

Expected result:
Chart component should render with the theme's chart padding values.

Actual Result:
Multiple runtime errors are thrown and the Chart component does not render correctly.

tlabaj pushed a commit that referenced this issue Jul 2, 2019
Add more robust logic for setting padding values in Chart component

fix #2429
@rachael-phillips rachael-phillips added this to the Bluebird milestone Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants