-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example styles for charts and alert #1889
Conversation
901c9e7
to
e04dcf0
Compare
PatternFly-React preview: https://1889-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #1889 +/- ##
=======================================
Coverage 82.62% 82.62%
=======================================
Files 623 623
Lines 6870 6870
Branches 93 93
=======================================
Hits 5676 5676
Misses 1154 1154
Partials 40 40
Continue to review full report at Codecov.
|
} | ||
|
||
.chart-title { | ||
margin-bottom: 25px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be using SASS variables for things that are common in overflow, title, container, margin, etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was just ported from previous examples and deleted, we can refactor later if you'd like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay we can do it later thought this was something new. Thanks.
Also fixes the code example for the docs site
addresses some of: #1724