Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF4 docs #1724

Closed
5 of 12 tasks
jschuler opened this issue Apr 8, 2019 · 6 comments
Closed
5 of 12 tasks

PF4 docs #1724

jschuler opened this issue Apr 8, 2019 · 6 comments
Assignees

Comments

@jschuler
Copy link
Collaborator

jschuler commented Apr 8, 2019

  • Fix font size (html should be set to 16px so that rem units can pick it up)
  • Font family should be Overpass everywhere
  • Some components are not rendering (LoginPage ((fixed via fix(login): added login subtitle #1696)), Background)
  • Layouts should be in their own nav category (feat(mdx): use mdx for docs #1753)
  • Layouts don't have visual borders anymore
  • Dark theme toggle button is missing
  • Fix hot reloading on code changes
  • Fix color scheme. It is hard to read the grey on grey. (Background should be white)

Additional:

@mcoker
Copy link
Contributor

mcoker commented Apr 9, 2019

Wrapping the examples in <pre> tags seems to be problematic. <pre> applies a lot of font and white-space changes we don't want in the examples. That should also help address some of the font size issues.

@jgiardino
Copy link
Collaborator

This may or may not be related to this issue. When this issue is fixed, can we check the following, and capture this as an issue if it's unrelated?

I'm seeing a difference in font size for the Alert description:
image

I only see this issue in Chrome, and it looks like Chrome is pulling the styles in twice.

@dlabaj
Copy link
Contributor

dlabaj commented Apr 10, 2019

Can this be broken out into separate smaller issues. This seems like a lot for one PR. Seems like each of the boxes should be their own issue.

@redallen
Copy link
Contributor

My plan is to split up the work over multiple PRs and just reference a few checkboxes on this issue each time.

@redallen
Copy link
Contributor

CSS mock for example padding
Screen Shot 2019-04-12 at 1 10 01 PM

@redallen
Copy link
Contributor

Closing in favor of patternfly/patternfly-org#1208 which will unify docs across repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants