-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(emptyState): add small/large modifiers #1729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boaz0 the PR to update core has been merged
Thanks @tlabaj I will rebase soon and let you know when it is ready for your review again. |
Signed-off-by: Boaz Shuster <[email protected]>
PatternFly-React preview: https://1729-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #1729 +/- ##
==========================================
+ Coverage 82.71% 82.72% +<.01%
==========================================
Files 598 598
Lines 6626 6629 +3
Branches 72 72
==========================================
+ Hits 5481 5484 +3
Misses 1118 1118
Partials 27 27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a bunch @redallen @christiemolloy, @dlabaj and @tlabaj 🙇♂️ 👏 |
What:
closes #1677
//cc @dlabaj @mcoker
Additional issues:
Don't merge this yet till:
@patternfly/patternfly@^2.0.0
is updated