Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emptyState): add small/large modifiers #1729

Merged
merged 1 commit into from
Apr 10, 2019
Merged

fix(emptyState): add small/large modifiers #1729

merged 1 commit into from
Apr 10, 2019

Conversation

boaz0
Copy link
Member

@boaz0 boaz0 commented Apr 8, 2019

What:

closes #1677

//cc @dlabaj @mcoker

Additional issues:

Don't merge this yet till:

  • @patternfly/patternfly@^2.0.0 is updated

dlabaj
dlabaj previously approved these changes Apr 9, 2019
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boaz0 the PR to update core has been merged

@boaz0
Copy link
Member Author

boaz0 commented Apr 10, 2019

Thanks @tlabaj I will rebase soon and let you know when it is ready for your review again.

@boaz0 boaz0 marked this pull request as ready for review April 10, 2019 17:32
@boaz0
Copy link
Member Author

boaz0 commented Apr 10, 2019

Hi @tlabaj / @dlabaj

Change is ready for review

Thanks.

@boaz0 boaz0 changed the title fix(emptyState): add isSmall/isLarge props fix(emptyState): add small/large modifiers Apr 10, 2019
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1729-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #1729 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
+ Coverage   82.71%   82.72%   +<.01%     
==========================================
  Files         598      598              
  Lines        6626     6629       +3     
  Branches       72       72              
==========================================
+ Hits         5481     5484       +3     
  Misses       1118     1118              
  Partials       27       27
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.34% <100%> (+0.02%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...react-core/src/components/EmptyState/EmptyState.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 698c101...ba197de. Read the comment docs.

@christiemolloy
Copy link
Member

The body text isn't wrapping within its parent in the React demo (for all 3 examples).. see Core vs React:

Screen Shot 2019-04-10 at 1 45 46 PM

Screen Shot 2019-04-10 at 1 45 53 PM

@redallen
Copy link
Contributor

That's likely not an issue with this PR, but with the new docs. You can compare it against the preview that has the first doc change here. I'll add it to #1724 which is tracking the broken doc site styles.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabaj dlabaj merged commit 4f97ba1 into patternfly:master Apr 10, 2019
@boaz0
Copy link
Member Author

boaz0 commented Apr 10, 2019

Thanks a bunch @redallen @christiemolloy, @dlabaj and @tlabaj 🙇‍♂️ 👏

@boaz0 boaz0 deleted the fixes_1677 branch April 10, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add small/large props to empty state
7 participants