Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processing-but-hiding-underscore-prefixed-dirs #414

Merged
merged 3 commits into from
Aug 14, 2016
Merged

processing-but-hiding-underscore-prefixed-dirs #414

merged 3 commits into from
Aug 14, 2016

Conversation

e2tha-e
Copy link
Contributor

@e2tha-e e2tha-e commented Jul 29, 2016

Addresses #408

Summary of changes:
Processing, but hiding from the UI, underscore-prefixed directories, since they are processed in PHP, and there is nothing in the spec forbidding them.

@dmolsen
Copy link
Member

dmolsen commented Jul 30, 2016

I've opened a spec issue for this just to formalize the request a little bit. I've voted but please double-check I summarized this correctly. I want to make sure we document a feature that should be implemented in both node and PHP.

pattern-lab/the-spec#27

@geoffp geoffp assigned geoffp and bmuenzenmeyer and unassigned geoffp Aug 1, 2016
@bmuenzenmeyer bmuenzenmeyer added this to the 2.4.0 milestone Aug 2, 2016
@bmuenzenmeyer bmuenzenmeyer merged commit b33ae78 into pattern-lab:dev Aug 14, 2016
@bmuenzenmeyer
Copy link
Member

I am accepting this - but will have to alter it a bit inside ui-rewrite branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants